Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show test failures of ci-meson as annotations #39513

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

user202729
Copy link
Contributor

Follow-up to #36938 and #37738 , this PR shows the test failures of ci-meson.yml workflow as GitHub annotations, which has the advantage that you don't need to scroll through the whole log to view the failed tests.

(actually I just search for Failed examples, but this is not foolproof)

Previously only build.yml got this feature.

There's a disadvantage, then the file and line numbers are no longer shown in the downloaded log file, instead only [error] is shown (but this is trivially fixable by printing the format in both old and new ways when --format github is passed). I think if everyone views the annotations instead of reading the raw log anyway, it shouldn't matter too much.

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes. (no functionality change)
  • I have updated the documentation and checked the documentation preview. (no documentation change)

⌛ Dependencies

Copy link

Documentation preview for this PR (built with commit 763521d; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@user202729
Copy link
Contributor Author

Looks like it's working. (before the change, the highlighted part would always be test-long or test-new instead.)

image

@saraedum saraedum requested a review from tobiasdiez February 13, 2025 18:04
@saraedum
Copy link
Member

Looks good to me. But maybe @tobiasdiez (or somebody else) could sign off on this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants