add of the function rank_support_of_vector #39510
Open
+81
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fchapoton
reviewed
Feb 13, 2025
fchapoton
reviewed
Feb 13, 2025
fchapoton
reviewed
Feb 13, 2025
|
Documentation preview for this PR (built with commit b8c384a; changes) is ready! 🎉 |
xcaruso
reviewed
Feb 14, 2025
| represent `\GF{q^m}`. The default basis is then `1,\beta,\ldots,\beta^{m-1}`. | ||
| ``sub_field``. If not specified, the default basis is | ||
| `1,\beta,\ldots,\beta^{m-1}` where `\beta` is the generator of the | ||
| multiplicative group of `\GF{q^m}` given by Sage. |
There was a problem hiding this comment.
Suggested change
| multiplicative group of `\GF{q^m}` given by Sage. | |
| multiplicative group of `\GF{q^m}` given by SageMath |
There was a problem hiding this comment.
By the way, I would not say the generator of the multiplicative group but just of generator of GF(q^m).
There was a problem hiding this comment.
The same remarks apply several times below.
Aaahh... I also had some minor comments. |
xcaruso
reviewed
Feb 14, 2025
Co-authored-by: Xavier Caruso <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We added the function rank_support_of_vector, allowing to compute the rank support of a vector over a finite field.
We also corrected some sentences in the documentation.
📝 Checklist