-
-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow CRT_list() to be called with one argument #38986
base: develop
Are you sure you want to change the base?
Conversation
Documentation preview for this PR (built with commit 7f199f2; changes) is ready! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few small things.
Co-authored-by: Travis Scrimshaw <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for loosing track of this one. LGTM. Thanks.
As in the title.
Opinion: should we allow
crt()
/CRT()
to be called with one list also? Note that currently it is callable with two lists and does the exact same thing asCRT_list()
.Opinion: is returning
Mod(0, 1)
for empty list a sane idea? Problem is later we may want to implement (pseudocode)and in that case the correct thing to return is not clear when the list is empty.
More generally, if it's given elements
x₁ ∈ R/I₁, …, xₙ ∈ R/Iₙ
whereIᵢ = xᵢ.parent().defining_ideal()
and allR = xᵢ.parent()
are the same for alli
, it should returnsx ∈ R/(I₁.intersection(I₂).intersection(I₃).….intersection(Iₙ))
. But this is not well-defined whenvalues
is empty.📝 Checklist