-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install cysignals-CSI-helper as package data for better portability #204
Conversation
Thanks for working on this. |
@mkoeppe any reason not to merge this? Without it, we guess the wrong path on Gentoo. |
This should be updated, as we don't deal with python < 3.9 here any more. @tobiasdiez - does this fit into the meson setup? |
Yes, one can easily control where the script should be installed. |
Rather than installing `cysignals-CSI-helper.py` into a `share` directory and then trying to figure out the correct path to it, install it as Python package data and use the standard `importlib.resources` API to access it. For Python versions older than 3.9, the `importlib_resources` backport is used instead. Fixes sagemath#200
Err, that PR doesn't apply cleanly to my branch, i.e. GH doesn't let me merge it. Feel free to just overwrite my branch (it's open to maintainers) or replace the PR. |
while maintainers are too busy, and I'm not one, the quickest way forward would be just to force-push my branch into your PR. |
2abd7ef
to
6d36c5f
Compare
Done. |
@vbraun - can you promote me to maintainer here, or otherwise take care of this and other PRs waiting here? |
I haven't figured out to invoke |
This still uses |
Rather than installing
cysignals-CSI-helper.py
into ashare
directory and then trying to figure out the correct path to it, install it as Python package data and use the standardimportlib.resources
API to access it. For Python versions older than 3.9, theimportlib_resources
backport is used instead.Fixes #200