Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "add --project-name" and check for exactly one positional argument #253

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

mgsloan
Copy link
Contributor

@mgsloan mgsloan commented Feb 20, 2024

See #252 for details of --project-name. This change causes --project-name to be preferred over --project-id whenever specified. An error will be reported if a project with that name cannot be found.

For the error about exactly one positional argument, there might be a nice alternative to instead intersperse the arguments with " ". To me the todoist add --help suggests that this should be possible:

todoist add [command options]

Instead, this just complains when there are positional arguments that are unused by the current logic.

Copy link
Owner

@sachaos sachaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late response.
LGTM

@sachaos sachaos merged commit e727ab0 into sachaos:master Oct 18, 2024
@mgsloan
Copy link
Contributor Author

mgsloan commented Oct 18, 2024

No worries, thanks for making this and sharing it!!! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants