-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: add Obsidian folder option #14
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the pr, I'll test it later today.
@saberzero1 I'm working to remove that commit, but so you understand why: I removed that path because I correlated it to the additional |
I think the problem is the method of link resolution. I use absolute path and it seems to work fine. You seem to use shortest path, which apparently doesn't work. I'll test your code to confirm if it works for both shortest path and absolute path. Ultimately I should probably let users configure their preferred option. Or perhaps get their preferred option from their |
@saberzero1 that's definitely it -- I do use shortest path. I backed out of the change but there's a bug in that behavior as noted. I'll consider that out of scope for this feature. Thanks! |
Closes #13