Changed colorbar and ghost to be a percentage #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was having an issue using your plugin and backbone. The problem was that the way views are rendered and appended to the page, there would be no initial size for data.positioner. Changing the math to work of width percentages was all that was needed.
|
I think I had it as a percentage once but some browser’s behaviour or certain circumstances had me change it to measure the width and calculate the percentage from it. But that was too long ago for me to remember exactly what the issue was. If you make it configurable in a backwards-compatible way, I’ll merge this. |
|
@jsmits21 What’s the status on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was having an issue using your plugin and backbone. The problem was that the way views are rendered and appended to the page, there would be no initial size for data.positioner. Changing the math to work of width percentages was all that was needed.