chore(skills): drop the skill usage counters; keep the author stamp - #537
Merged
Merged
Conversation
The load and revision counters were built for a curator that is on hold, and for a person in the Agent editor they rarely change anything: every revision already shows up as a tool card in its chat and as a change to the note. They cost a plugin-data write, and so a sync, on every skill load. Removed: the recording in load_skill and manage_skills, the stored list, the delete-path bookkeeping, and the usage line in the editor. The `metadata.author: agent` stamp on created skills stays as plain provenance, like `author: S2B` on the bundled ones. The 2.3.0 changelog entry for the usage line goes with it. Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the per-skill load and revision counters from #516, keeping the
metadata.author: agentstamp thatcreatewrites.The counters were built for a curator (on hold since the post-turn review was removed in #532), and for a person reading the Agent editor they rarely change anything. A revision already shows up as a
manage_skillscard in its chat and as a change to the skill note, and a bundled skill that was revised is already flagged as customized. Meanwhile every skill load wrote the plugin data file, which syncs.Removed:
load_skill(therecordUsageoption) and inmanage_skills(revisions, and forgetting on delete)PluginData.skillUsage,SkillUsageEntry, and the store's record/get/forget methodsSkillsService.deleteSkillsrc/skills/usageSummary.tsKept: the
author: agentstamp on created skills, as plain provenance in the same key the bundled skills use forS2B. Nothing in the plugin reads it; its doc comment now says so.No migration: #516 has not shipped in a stable release. A 2.3.0 beta install keeps an unused
skillUsagelist in its plugin data; nothing reads it.How I tested it
bun run check,format,lint, and the full unit suite (1989) pass. The deleteSkill test keeps its file-removal checks without the counters. Built into theS2B WT1slot vault and reloaded with no console errors.AI assistance: Claude Code (Fable 5.1) removed the counters from Leo's decision after discussing whether usage data is useful without a curator; Leo reviews and tests live.
Checklist
bun run check,bun run format,bun run lint, andbun run testpass locallymanifest.json: I noted that the docs site needs updating (see "Documentation" in CONTRIBUTING.md) — the skills page's "Where a skill came from" is trimmed in a companion site PR