Open
Conversation
Contributor
Author
|
Confirmed with AAVSO that new URLs are considered 'live' and that moving to them ASAP is advisable. Also, redirects for old URLs should be functional for at least 3 months, so it should be some time before folks running existing code will break - but it'd be advisable to announce that at the appropriate time. |
Collaborator
|
Obviously the redirects have been active for a bit longer than 3 months... :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is in response to announced change in AAVSO API URLs, due to come into effect on 2025/05/31. I've tested these with current state of the APIs - the new URLs do appear to be live, at present - but we probably should wait to integrate these until they have completed their update and I can test again with them in their new updated state.
The existing APIs are expected to work for some time - the 'requests' package does handle 301 redirects transparently, and it appears that the updated code is compatible enough to not require additional changes - but AAVSO has indicated that the redirects are temporary.