fix: enable agentic recovery for sub-recipe failures (#2953)#2967
Merged
fix: enable agentic recovery for sub-recipe failures (#2953)#2967
Conversation
…rator Add recovery_on_failure: true to both sub-recipe invocation steps (execute-single-round-1 and execute-single-fallback-blocked). When default-workflow fails at an individual step but the agent actually recovers and completes the work, the recipe runner now attempts agentic recovery instead of reporting binary failure. This addresses the scenario where e.g. branch name generation fails (#2952) but the agent works around it on the current branch — previously reported as FAILED despite all work being completed. Relates to #2953 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
|
🤖 Auto-fixed version bump The version in If you need a minor or major version bump instead, please update |
Contributor
Repo Guardian - PassedAll files in this PR are durable configuration changes:
No ephemeral content detected.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
recovery_on_failure: trueto both sub-recipe invocation steps insmart-orchestrator.yaml:execute-single-round-1(primary single-workstream execution)execute-single-fallback-blocked(fallback when parallel spawning is blocked)Problem
When
default-workflowfails at an individual step (e.g., branch name too long per #2952), the smart-orchestrator reports the entire recipe as FAILED — even when the agent within the sub-recipe actually recovered and completed all the work (commits, tests, push).Fix
The Rust recipe runner already implements
recovery_on_failure(runner.rs:712-762) — it invokes an agent to assess the failure and attempt recovery. The feature just wasn't enabled on the smart-orchestrator's sub-recipe steps.With this change, when a sub-recipe fails:
Companion PR
recovery_on_failureandmodelto the parser validator's whitelist (fixes spurious "unrecognized field" warnings)Test plan
--validate-only(after companion PR)Fixes #2953
🤖 Generated with Claude Code