Skip to content

feat: add skill_invocation power-steering check (from closed #2916)#2926

Merged
rysweet merged 2 commits intomainfrom
feat/2914-skill-invocation-check
Mar 7, 2026
Merged

feat: add skill_invocation power-steering check (from closed #2916)#2926
rysweet merged 2 commits intomainfrom
feat/2914-skill-invocation-check

Conversation

@rysweet
Copy link
Owner

@rysweet rysweet commented Mar 7, 2026

Summary

Extracts the skill_invocation check from closed PR #2916 (which was closed due to merge conflicts with the package refactor, not because the work was bad).

This check detects when a user requests a skill via slash command (e.g. /pm-architect) but the agent bypasses it and responds directly without invoking the Skill tool.

Changes

  • checks_workflow.py: Add _check_skill_invocation() method with try/except fail-open
  • considerations.yaml: Add skill_invocation blocker for DEVELOPMENT, INVESTIGATION, MAINTENANCE sessions
  • 12 outside-in e2e tests covering Claude, Copilot, and edge cases

How it works

  1. Scans transcript for <command-name> tags (injected when user runs a slash command)
  2. If found, checks if the Skill tool was called with that skill name
  3. If no command-name tag → auto-pass (check not applicable)
  4. If skill requested but not invoked → fail (blocker)

Related to #2914

Test plan

  • 12 outside-in tests pass (Claude + Copilot sessions)
  • 70 existing PS tests still pass
  • CI checks pass

Generated with Claude Code

Ubuntu and others added 2 commits March 7, 2026 22:03
Detects when a user requests a skill via slash command (<command-name> tag)
but the agent bypasses it and responds directly without invoking the Skill
tool. This was independently valuable work from closed PR #2916 that got
dropped during the stale PR cleanup.

- checks_workflow.py: Add _check_skill_invocation method
- considerations.yaml: Add skill_invocation blocker for DEV/INVESTIGATION/MAINTENANCE
- 12 outside-in tests (Claude + Copilot + edge cases)

Related to #2914

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@github-actions
Copy link
Contributor

github-actions bot commented Mar 7, 2026

🤖 Auto-fixed version bump

The version in pyproject.toml has been automatically bumped to the next patch version.

If you need a minor or major version bump instead, please update pyproject.toml manually and push the change.

@rysweet rysweet merged commit 4f34508 into main Mar 7, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant