-
Notifications
You must be signed in to change notification settings - Fork 1
Implementing hierarchical distributor #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ryanstocks00
wants to merge
94
commits into
main
Choose a base branch
from
hierarchical
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
94 commits
Select commit
Hold shift + click to select a range
f65e640
Implementing hierarchical distributor
ryanstocks00 2d0357e
Update leak suppressions
ryanstocks00 c05bfd1
A bit of cleanup
ryanstocks00 47b7362
Added missing include
ryanstocks00 7556b97
Hopefully make msvc happy
ryanstocks00 ce38e0f
Fix and test printing functions
ryanstocks00 c85918a
Small test improvements
ryanstocks00 206d592
Gather task counts
ryanstocks00 5c62ccb
Additonal assert
ryanstocks00 5878987
Test asserts
ryanstocks00 707656f
m_ for member variables
ryanstocks00 8eee9da
Fixing assert tests
ryanstocks00 6062b70
Added test for assert during throw
ryanstocks00 82d0ba0
Maybe not constexpr
ryanstocks00 369f707
Frontier benchmarking
ryanstocks00 5614551
Formatting fixes
ryanstocks00 e0b15cd
Fixed undefined variable
ryanstocks00 9fd8fb8
Small CI fixes
ryanstocks00 cc340c7
Code review fixes
ryanstocks00 ef1bca6
Bug fix
ryanstocks00 eadfc3a
Fix error handling
ryanstocks00 23751b7
Propogate errors properly
ryanstocks00 f8a37c2
Merge branch 'main' into hierarchical
ryanstocks00 3e1cc27
Maybe fixed deadlocking
ryanstocks00 e20968c
Fix unused variable and apache 2
ryanstocks00 9fbe32b
Maybe fixed?
ryanstocks00 39a6d8d
Fix stupid deadlock
ryanstocks00 f54a100
Hopefully fixed deadlock
ryanstocks00 e57ffd5
Hopefully fixed deadlock
ryanstocks00 6945633
Extend CI and no parallels
ryanstocks00 c05b22b
Less children per worker
ryanstocks00 a4b3627
Barrier after distribution
ryanstocks00 079c1f7
Don't run big tests in CI
ryanstocks00 2a525cd
Better cast
ryanstocks00 9e675dd
Fixes
ryanstocks00 8c5c2d4
Fix codacy issues
ryanstocks00 9c52611
Remove barrier
ryanstocks00 5d3b655
coverage
ryanstocks00 db2b477
Don't finalize inside error handling
ryanstocks00 57eb778
Aurora scripts
ryanstocks00 76c29af
Aurora scripts
ryanstocks00 1995d5a
Aurora scripts
ryanstocks00 8d749ed
aurora compile
ryanstocks00 d4ef865
aurora fixes
ryanstocks00 7c345a6
Update launch scripts
ryanstocks00 10d52ac
Write to different csv files
ryanstocks00 726fd88
First pass results
ryanstocks00 b2d9f8d
More strong scaling calcs
ryanstocks00 485aea7
Spin wait correct units
ryanstocks00 6023954
Specify frontier account
ryanstocks00 fa01286
Partial distributions
ryanstocks00 8f8ea16
Frontier use 56 ranks per node
ryanstocks00 4603f5b
Shift finalize
ryanstocks00 4a708d7
Shift finalize
ryanstocks00 3ebcaf6
New benchmark
ryanstocks00 be1ab38
Improved distribution benchmark
ryanstocks00 53e001c
Frontier results
ryanstocks00 3652a81
Test timer resolution and launch script
ryanstocks00 83cf773
CI fixes
ryanstocks00 f578b97
Better benchmark
ryanstocks00 372396d
More fixes
ryanstocks00 5dd2c7b
Frontier results
ryanstocks00 4941b77
Cleaning up duplications
ryanstocks00 96967d6
Naive distributer cleanup
ryanstocks00 1732ecd
Removed error handling for now
ryanstocks00 a1b6e02
Some refactoring
ryanstocks00 ac1e8f4
Naive distributer perf improvement?
ryanstocks00 1b7f803
Aurora strong scaling with software matching
ryanstocks00 f086935
Minor improvements
ryanstocks00 a85c92a
Remove return new results only
ryanstocks00 e750e41
Stop distributing benchmark
ryanstocks00 329bb78
Cleanup aurora scaling output
ryanstocks00 b84ce90
Use short job id
ryanstocks00 2e7d297
Fixed naive shutdown benchmark
ryanstocks00 0dde562
Frontier shutdown results
ryanstocks00 ff4f178
f
ryanstocks00 14418e1
First batch aurora shutdown
ryanstocks00 2ed2c4a
More auroras
ryanstocks00 cb4e475
Improved shutdown plot
ryanstocks00 b30700f
nodelocal
ryanstocks00 afce53c
More frontier results
ryanstocks00 9fe8a51
MPI C Bool
ryanstocks00 0071f22
Merge pull request #6 from ryanstocks00/nodelocal
ryanstocks00 da188e7
Safe MPI Group
ryanstocks00 521d084
Use groups for hierarchical
ryanstocks00 4739f1f
More testing
ryanstocks00 2daadcc
Merge branch 'main' into hierarchical
ryanstocks00 bef9929
Fix test ordering
ryanstocks00 20ef237
Print job submission commands
ryanstocks00 8e3717e
Better printing
ryanstocks00 8c38ba5
Adapt to aurora being difficult
ryanstocks00 444a915
Improving coverage and aurora being special
ryanstocks00 99b496e
Add cppcheck
ryanstocks00 a56b71d
Simplify process_incoming_message
ryanstocks00 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,3 +8,6 @@ bin | |
| Testing | ||
| *.btr | ||
| commands.txt | ||
| core.* | ||
| __pycache__/ | ||
| *.png | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| version = 1 | ||
|
|
||
| [[annotations]] | ||
| path = "benchmark/results/**.csv" | ||
| SPDX-FileCopyrightText = "2025 QDX Technologies" | ||
| SPDX-License-Identifier = "Apache-2.0" | ||
| SPDX-Comment = "Generated benchmark results." | ||
|
|
||
| [[annotations]] | ||
| path = "**.png" | ||
| SPDX-FileCopyrightText = "2025 QDX Technologies" | ||
| SPDX-License-Identifier = "Apache-2.0" | ||
| SPDX-Comment = "Generated result plots." |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| #!/usr/bin/env bash | ||
|
|
||
| # SPDX-FileCopyrightText: 2025 QDX Technologies. Authored by Ryan Stocks <ryan.stocks00@gmail.com> | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| set -euo pipefail | ||
|
|
||
| module load cmake | ||
|
|
||
| # Default values | ||
| BUILD_DIR="build" | ||
| BUILD_TYPE="Release" | ||
|
|
||
| usage() { | ||
| echo "Usage: $0 [-d build_dir] [-t build_type] [--clean]" | ||
| echo | ||
| echo "Options:" | ||
| echo " -d DIR Build directory (default: build)" | ||
| echo " -t TYPE Build type: Release, Debug, RelWithDebInfo, MinSizeRel (default: Release)" | ||
| echo " --clean Remove build directory before configuring" | ||
| exit 1 | ||
| } | ||
|
|
||
| # Parse args | ||
| CLEAN=0 | ||
| while [[ $# -gt 0 ]]; do | ||
| case "$1" in | ||
| -d) BUILD_DIR="$2"; shift 2 ;; | ||
| -t) BUILD_TYPE="$2"; shift 2 ;; | ||
| --clean) CLEAN=1; shift ;; | ||
| -h|--help) usage ;; | ||
| *) echo "Unknown option: $1"; usage ;; | ||
| esac | ||
| done | ||
|
|
||
| if [[ $CLEAN -eq 1 && -d "$BUILD_DIR" ]]; then | ||
| echo "Cleaning $BUILD_DIR" | ||
| rm -rf "$BUILD_DIR" | ||
| fi | ||
|
|
||
| echo "Configuring with CMake..." | ||
| cmake -DCMAKE_BUILD_TYPE="$BUILD_TYPE" -B "$BUILD_DIR" | ||
|
|
||
| echo "Building..." | ||
| cmake --build "$BUILD_DIR" -- -j"$(nproc)" | ||
|
|
||
| echo "✅ Build finished in $BUILD_DIR ($BUILD_TYPE)" | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.