golangci-lint

golangci-lint golangci-lint # #59

Triggered via push February 6, 2025 15:39

ryanreadbooks

pushed 0d594c4

master

Status Success

Total duration 1m 56s

Artifacts –

golangci-lint.yml

on: push

detect-modules

Matrix: golangci-lint

Annotations

53 errors and 11 warnings

golangci-lint (/home/runner/work/whimer/whimer/analysis)

golangci-lint exit with code 5

golangci-lint (/home/runner/work/whimer/whimer/feed): feed/internal/infra/dep/dep.go#L27

var `err` is unused (unused)

golangci-lint (/home/runner/work/whimer/whimer/feed)

issues found

golangci-lint (/home/runner/work/whimer/whimer/api-x): api-x/internal/backend/notehandler.go#L129

SA1019: note.NoteCreatorServer().BatchGetUploadAuth is deprecated: BatchGetUploadAuth is deprecated, use BatchGetUploadAuthV2 instead. (staticcheck)

golangci-lint (/home/runner/work/whimer/whimer/api-x): api-x/internal/backend/passport/client.go#L13

var `err` is unused (unused)

golangci-lint (/home/runner/work/whimer/whimer/api-x): api-x/internal/backend/comment/model.go#L14

SA5008: unknown JSON option "optional" (staticcheck)

golangci-lint (/home/runner/work/whimer/whimer/api-x): api-x/internal/backend/comment/model.go#L15

SA5008: unknown JSON option "optional" (staticcheck)

golangci-lint (/home/runner/work/whimer/whimer/api-x)

issues found

golangci-lint (/home/runner/work/whimer/whimer/relation): relation/internal/infra/dep/dep.go#L12

var `err` is unused (unused)

golangci-lint (/home/runner/work/whimer/whimer/relation): relation/internal/infra/dao/relation_test.go#L41

Error return value of `relationDao.Insert` is not checked (errcheck)

golangci-lint (/home/runner/work/whimer/whimer/relation): relation/internal/infra/dao/relation_test.go#L60

Error return value of `relationDao.Insert` is not checked (errcheck)

golangci-lint (/home/runner/work/whimer/whimer/relation): relation/internal/infra/dao/relation_test.go#L115

Error return value of `relationDao.Insert` is not checked (errcheck)

golangci-lint (/home/runner/work/whimer/whimer/relation): relation/internal/infra/dao/relation.go#L172

var `sqlFindUidRelation` is unused (unused)

golangci-lint (/home/runner/work/whimer/whimer/relation)

issues found

golangci-lint (/home/runner/work/whimer/whimer/counter): counter/internal/svc/counter.go#L144

Error return value of `s.updateSummaryNow` is not checked (errcheck)

golangci-lint (/home/runner/work/whimer/whimer/counter): counter/internal/svc/counter_test.go#L22

Error return value of `svc.SyncSummaryFromRecords` is not checked (errcheck)

golangci-lint (/home/runner/work/whimer/whimer/counter): counter/internal/svc/counter.go#L46

func `(*CounterSvc).summaryKey` is unused (unused)

golangci-lint (/home/runner/work/whimer/whimer/counter): counter/internal/svc/counter.go#L167

func `(*CounterSvc).cacheSummary` is unused (unused)

golangci-lint (/home/runner/work/whimer/whimer/counter)

issues found

golangci-lint (/home/runner/work/whimer/whimer/comment): comment/internal/srv/comment.go#L231

ineffectual assignment to err (ineffassign)

golangci-lint (/home/runner/work/whimer/whimer/comment): comment/internal/infra/dep/dep.go#L21

var `err` is unused (unused)

golangci-lint (/home/runner/work/whimer/whimer/comment): comment/internal/infra/dep/dep.go#L62

S1000: should use for range instead of for { select {} } (gosimple)

golangci-lint (/home/runner/work/whimer/whimer/comment): comment/internal/infra/dao/comment_cache.go#L17

const `hour` is unused (unused)

golangci-lint (/home/runner/work/whimer/whimer/comment): comment/internal/infra/dao/comment_cache.go#L18

const `day` is unused (unused)

golangci-lint (/home/runner/work/whimer/whimer/comment): comment/internal/infra/dao/comment_cache.go#L19

const `week` is unused (unused)

golangci-lint (/home/runner/work/whimer/whimer/comment): comment/internal/infra/dao/comment_op.go#L53

const `sqlSetLike` is unused (unused)

golangci-lint (/home/runner/work/whimer/whimer/comment): comment/internal/infra/dao/comment_op.go#L54

const `sqlSetDisLike` is unused (unused)

golangci-lint (/home/runner/work/whimer/whimer/comment): comment/internal/infra/dao/comment_op.go#L55

const `sqlSetReport` is unused (unused)

golangci-lint (/home/runner/work/whimer/whimer/comment): comment/internal/biz/comment.go#L132

Error return value of `.IncrReplyCount` is not checked (errcheck)

golangci-lint (/home/runner/work/whimer/whimer/misc): misc/xgrpc/client.go#L106

S1000: should use for range instead of for { select {} } (gosimple)

golangci-lint (/home/runner/work/whimer/whimer/misc): misc/recovery/do.go#L15

printf: non-constant format string in call to github.com/ryanreadbooks/whimer/misc/xerror.Wrapf (govet)

golangci-lint (/home/runner/work/whimer/whimer/misc): misc/stacktrace/stack_test.go#L11

Error return value is not checked (errcheck)

golangci-lint (/home/runner/work/whimer/whimer/misc): misc/stacktrace/stack_test.go#L15

Error return value is not checked (errcheck)

golangci-lint (/home/runner/work/whimer/whimer/misc): misc/utils/maps/maps_test.go#L16

Error return value is not checked (errcheck)

golangci-lint (/home/runner/work/whimer/whimer/misc): misc/xhttp/router_test.go#L89

Error return value of `http.DefaultClient.Do` is not checked (errcheck)

golangci-lint (/home/runner/work/whimer/whimer/misc): misc/xhttp/router_test.go#L92

Error return value of `http.DefaultClient.Do` is not checked (errcheck)

golangci-lint (/home/runner/work/whimer/whimer/misc): misc/xhttp/router_test.go#L95

Error return value of `http.DefaultClient.Do` is not checked (errcheck)

golangci-lint (/home/runner/work/whimer/whimer/misc): misc/oss/signer/signer.go#L18

field `user` is unused (unused)

golangci-lint (/home/runner/work/whimer/whimer/misc): misc/oss/signer/signer.go#L19

field `password` is unused (unused)

golangci-lint (/home/runner/work/whimer/whimer/note): note/internal/infra/dao/daotx.go#L61

SA1032: arguments have the wrong order (staticcheck)

golangci-lint (/home/runner/work/whimer/whimer/note)

issues found

golangci-lint (/home/runner/work/whimer/whimer/asset-job): asset-job/internal/srv/noteimage.go#L29

const `previewSuffix` is unused (unused)

golangci-lint (/home/runner/work/whimer/whimer/asset-job)

issues found

golangci-lint (/home/runner/work/whimer/whimer/passport): passport/internal/model/contexts.go#L15

SA1029: should not use built-in type string as key for value; define your own type to avoid collisions (staticcheck)

golangci-lint (/home/runner/work/whimer/whimer/passport): passport/internal/model/contexts.go#L20

SA1029: should not use built-in type string as key for value; define your own type to avoid collisions (staticcheck)

golangci-lint (/home/runner/work/whimer/whimer/passport): passport/internal/model/sms.go#L17

SA5008: unknown JSON option "optional" (staticcheck)

golangci-lint (/home/runner/work/whimer/whimer/passport): passport/internal/model/sms.go#L39

SA5008: unknown JSON option "optional" (staticcheck)

golangci-lint (/home/runner/work/whimer/whimer/passport): passport/internal/infra/dep/dep.go#L17

var `err` is unused (unused)

golangci-lint (/home/runner/work/whimer/whimer/passport): passport/internal/infra/dep/dep.go#L45

S1000: should use for range instead of for { select {} } (gosimple)

golangci-lint (/home/runner/work/whimer/whimer/passport): passport/internal/infra/dao/user_test.go#L31

Error return value of `dao.Delete` is not checked (errcheck)

golangci-lint (/home/runner/work/whimer/whimer/passport): passport/internal/infra/dao/user_test.go#L59

Error return value of `dao.Delete` is not checked (errcheck)

golangci-lint (/home/runner/work/whimer/whimer/passport): passport/internal/infra/dao/user_test.go#L90

Error return value of `dao.Delete` is not checked (errcheck)

golangci-lint (/home/runner/work/whimer/whimer/passport): passport/internal/infra/dao/user_cache.go#L22

func `getCacheUserBaseTelKey` is unused (unused)

detect-modules