Fix service destroyed with activity #846
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nt4f04uNd
force-pushed
the
fix-idle
branch
2 times, most recently
from
d5b480e to
fe16ec2
Compare
|
Apologies, my latest commit has introduced a conflict here. |
|
Although this change seems logical, I'm starting to rethink how this should best work, by analogy to just_audio's playing and processing states. I will need some time to formulate my thoughts... |
|
I suspect that in any case this will be a breaking change, so I may need to publish the non-breaking changes first. |
|
fwiw, this is a bugfix and could easily be merged in minor |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #834
Tried to summarize what was happening in the comments