Repository navigation
Add Nn::StatefulTransducerOnnxLabelScorer #149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
540c311
Introduce finalizeScoringContext function for updating hidden states
larissakl 39888ef
Refactor: Handle finalization internally in LabelScorer
SimBe195 ad702b3
Revert docstring in LabelScorer
SimBe195 1b9a55e
Add StatefulTransducerOnnxLabelScorer class
SimBe195 c167092
Remove wrong verify
SimBe195 5c67ff7
Remove wrong timeframe insertion
SimBe195 b3728ec
Actually use `finalizeScoringContext`
SimBe195 b2d150c
Merge branch 'master' into transducer_label_scorer
SimBe195 63c4d74
Update interface and add batching and state caching like in StatefulO…
SimBe195 3c914be
Apply suggestions from code review
SimBe195 f81fbbc
Cache state of already finalized scoring contexts
SimBe195 a3423e8
Merge branch 'master' into transducer_label_scorer
SimBe195 c6ab994
Merge branch 'master' into transducer_label_scorer
SimBe195 dbd0ef7
Move StepOnnxHiddenStateScoringContext next to corresponding label sc…
SimBe195 9ee4f69
Introduce OnnxHiddenStateModel to refactor out common behavior betwee…
SimBe195 d45c6d6
Rename `ExtraInputs` to `SessionInputs`
SimBe195 96bf61e
Merge branch 'master' into transducer_label_scorer
SimBe195 7246118
Merge branch 'master' into transducer_label_scorer
curufinwe 8172020
Count the transducer state initializer towards the scoring time
curufinwe a0493c5
Order method definitions like their declarations
curufinwe f6f7220
Move OnnxHiddenStateModel to Onnx and guard ONNX label scorers
curufinwe 3d53448
Guard the ONNX state manager code in Nn::Module
curufinwe 4e8c906
Update docs
larissakl 7dab3c4
Rename OnnxHiddenStateModel to OnnxInitUpdateScoreBundle
curufinwe a41d950
Key the transducer state cache by the label sequence only
curufinwe 6b65bd3
Address review comments on StatefulTransducerOnnxLabelScorer
curufinwe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This header uses
Math::FastMatrix(ctcScores_, theCtcPrefixScoreAccessorconstructor) but never included it. It only compiled because the type arrived transitively:LabelScorer.hh→DataView.hh→Onnx/Value.hh→Math/FastMatrix.hh.DataView.hhincludesOnnx/Value.hhonly under#ifdef MODULE_ONNX, so on master a build with-DMODULE_ONNX=OFFalready fails here.The previous state of this PR hid that, because
ScoringContext.hhincludedOnnx/Value.hhunconditionally (forOnnxHiddenState). Now thatOnnxHiddenStatelives inOnnx/OnnxHiddenStateModel.hhandScoringContext.hhis back to master's version, the transitive path is gone in ONNX-off builds. The explicit include fixes that; the ONNX-off build is green with it.— Claude Code