-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make label loops optional in CtcTreeBuilder for RNA topology support #100
base: master
Are you sure you want to change the base?
Conversation
# Conflicts: # src/Search/AdvancedTreeSearch/PersistentStateTree.cc # src/Search/AdvancedTreeSearch/TreeBuilder.cc
# Conflicts: # src/Search/TreeBuilder.hh
Update: I introduced the
I’m still unsure about the code style and the intended behavior, so feel free to share feedback or make any necessary changes directly. |
Move the allow-label-loop parameter into CtcTreeBuilder and also add it to RnaTreeBuilder, but with a different default value. Then in the RnaTreeBuilder call the parent constructor and afterwards initialize the allowLabelLoop_ member again with the parameter that is inside RnaTreeBuilder. |
# Conflicts: # src/Search/AdvancedTreeSearch/AcousticLookAhead.hh # src/Search/AdvancedTreeSearch/LanguageModelLookahead.hh # src/Search/AdvancedTreeSearch/LinearPrediction.hh # src/Search/AdvancedTreeSearch/SearchSpace.cc # src/Search/AdvancedTreeSearch/SearchSpace.hh # src/Search/Module.cc # src/Search/Module.hh # src/Search/PersistentStateTree.cc # src/Search/TreeBuilder.cc # src/Search/TreeBuilder.hh # src/Search/TreeStructure.hh
As discussed in #99, the difference between the
CtcTreeBuilder
and a tree builder for Transducer/RNA topology is minimal and a dedicatedTransducerTreeBuilder
subclass can be avoided.Therefore I introduced a member
labelLoops_
toCtcTreeBuilder
, which determines whether self-loops on the non-blank labels are added (CTC topology) or not (RNA topology).Depends on #98.