Split nn.py #172
Closed
Split nn.py #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Atticus1806
requested review from
christophmluscher,
JackTemaki,
michelwi and
vieting
JackTemaki
reviewed
Sep 13, 2023
| use_python_control: Optional[bool] | ||
|
|
||
|
|
||
| NnTrainingArgs = ReturnnRasrTrainingArgs # Legacy compatibility |
There was a problem hiding this comment.
The name ReturnnRasrTrainingArgs is already used in data, this is very confusing if the same name appears twice with a superset of parameters and (possibly?) different usage.
JackTemaki
requested changes
Sep 13, 2023
|
|
||
|
|
||
| @dataclass() | ||
| class NnRecogArgs: |
There was a problem hiding this comment.
The same class appearing twice? This can not be correct. I assume we can just delete the first version then?
There was a problem hiding this comment.
This is marked Todo by @christophmluscher so maybe he can give more information on the thoughts here / how to proceed
|
I created my own PR. Syncing with @Atticus1806 PR was annoying... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prequesite for #151
Refactoring was done by @christophmluscher