update diesel-async to 0.4.1 #2641
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The CI error seems to be unrelated, looks like it originates from this error only present on |
|
I'm happy to merge this once we have CI passing. Otherwise, we're going to get failures for every commit moving forward. |
|
Thanks, understandable. Looks like a fix is already done for Rustc, waiting to be accepted and merged, so hopefully it doesn't take long to get it on Nightly |
Please ping me as soon as it is! |
|
Should be working now with Nighlty 2023-11-09, please re-run the CI @SergioBenitez |
|
Excellent! Merged in 1c3342d. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating diesel-async to 0.4.1 to support Diesel migrations. See https://github.com/weiznich/diesel_async/blob/main/CHANGELOG.md?plain=1#L17
This will probably solve the trait issue in #2640