Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade 'tokio-tungstenite' to 0.20. #2629

Closed
wants to merge 1 commit into from

Conversation

BlackDex
Copy link
Contributor

Cherry-Pick tungstenite update to v0.5 branch.
This ensures applications which use the contrib/ws to use a patched version which has a known CVE https://github.com/snapview/tokio-tungstenite/blob/master/CHANGELOG.md#0201

@SergioBenitez
Copy link
Member

As noted on Matrix, the vulnerability in tungstenite doesn't affect rocket_ws as we don't make use of its HTTP handshaking functionality.

@SergioBenitez
Copy link
Member

I just finished cherry picking every possible commit from master to 0.5-rc, which included this commit. I preferred to do it this way to keep the commits in relative order.

@BlackDex
Copy link
Contributor Author

Thx!

@BlackDex BlackDex deleted the cherry-pick-tungstenite-update branch October 23, 2024 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants