Modify fairings #2598
Modify fairings #2598
Conversation
SergioBenitez
force-pushed
the
modify-fairings
branch
2 times, most recently
from
7f969ec
to
1cafc72
Compare
|
I went a bit of a different direction with this one that I think results in a nicer API that can be used in more situations. It necessitated a bit of tricky code in the fairings set, but thankfully that complexity doesn't leak to the user, and there's no |
Introduces four new methods: * `Rocket::fairing::<F>()` * `Rocket::fairing_mut::<F>()` * `Rocket::fairings::<F>()` * `Rocket::fairings_mut::<F>()` These methods allow retrieving references to fairings of type `F` from an instance of `Rocket`. The `fairing` and `fairing_mut` methods return a (mutable) reference to the first attached fairing of type `F`, while the `fairings` and `fairings_mut` methods return an iterator over (mutable) references to all attached fairings of type `F`. Co-authored-by: Matthew Pomes <[email protected]>
SergioBenitez
force-pushed
the
modify-fairings
branch
from
1cafc72
to
2e73a7c
Compare
There was a problem hiding this comment.
I like the changes. My original PR was intended to work with a specific use-case, but I think the final API works just fine.
The only thing I see is that you can technically call fairings_mut on a Rocket<Orbit>, but I don't think there's any point during the Rocket lifecycle this is actually possible outside of Rocket. I don't think this is an issue, since there isn't much you could do at that point anyway.
(Btw, I'd post an approval, but I can't approve my own PR).
Supersedes: #2271
Resolves: #2271
Adds a modify_fairings method to make changes to fairings before launch.
There were several comments on the original PR, which have been resolved. Some simplification of the API has been performed.