fix(reflow): support multiple backticks and optimize code span parsing#724
Closed
chandlerc wants to merge 1 commit into
Closed
fix(reflow): support multiple backticks and optimize code span parsing#724chandlerc wants to merge 1 commit into
chandlerc wants to merge 1 commit into
Conversation
Update parse_markdown_elements_inner to identify and extract inline code spans using pre-extracted ranges from pulldown-cmark instead of manual character-by-character single-backtick matching. This fixes the parser to correctly handle code spans delimited by multiple backticks (e.g., double backticks) as atomic code elements conforming to the CommonMark spec. It also eliminates the custom backtick parser loop, ensuring code spans are parsed in linear O(N) time. Stored Element::Code representation is updated to retain its original delimiters, and its Display implementation is updated to render it raw. Assisted-by: Antigravity with Gemini
Owner
|
Verified and landed on main as 81944c5, cherry-picked with your authorship preserved (the branch had conflicted with the #728 reflow fix that touched the same test module, so I resolved locally rather than round-tripping a rebase). Verification notes: on main, The finder's rescan-from-start over the code spans was replaced with a monotonic cursor index in a30a4f9, together with the same pattern for the link and emphasis scans. Thanks for the fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update parse_markdown_elements_inner to identify and extract inline code spans using pre-extracted ranges from pulldown-cmark instead of manual character-by-character single-backtick matching.
This fixes the parser to correctly handle code spans delimited by multiple backticks (e.g., double backticks) as atomic code elements conforming to the CommonMark spec. It also eliminates the custom backtick parser loop, ensuring code spans are parsed in linear O(N) time. Stored Element::Code representation is updated to retain its original delimiters, and its Display implementation is updated to render it raw.
Assisted-by: Antigravity with Gemini