test(action): restore malformed fixture and widen test-action.yml paths filter#713
Merged
Merged
Conversation
added 2 commits
July 11, 2026 12:29
__tests__/fixtures/malformed/bad.md is used by test-action.yml to verify the Action correctly fails/reports on malformed markdown. 497ab92 (test: add coverage for fmt command, rule aliases, and JSONC import) added a space after "##" as an incidental side effect of unrelated CLI test coverage work, turning this fixture into valid markdown. The breakage stayed invisible because test-action.yml only triggers on changes to action.yml/scripts/rumdl-action.sh, and no PR has touched those paths since (last green run: 2026-02-14, before 497ab92). Any future PR that does touch those paths would otherwise surface 4 unrelated red jobs (test-args, test-expected-failure, test-combined-informational-with-output, test-output-file-with-violations). Verified against a real rumdl binary: restoring the original 2-line content yields MD018 + 2x MD022 (exit 1), and still exits 1 with the remaining MD022s when --extend-disable MD018 is applied, matching what all 4 affected jobs assert.
test-action.yml only triggered on changes to action.yml/scripts/rumdl-action.sh, so a change that silently broke __tests__/fixtures/malformed/bad.md sat undetected since April. Add __tests__/fixtures/** and the workflow file itself to the paths filters so this class of breakage triggers CI.
rvben
approved these changes
Jul 12, 2026
rvben
left a comment
rvben
left a comment
Owner
There was a problem hiding this comment.
Verified end to end: the restored fixture trips MD018, MD041, and MD047, and still fails with MD018 disabled, which is what test-args needs. The upstream Test Action run on this PR is all green, and the fact that it triggered at all confirms the widened paths filter fires. The original pre-April fixture had a # Bad markdown title line, so this isn't byte-identical, but it's functionally equivalent for every job that uses it. Merging this first so #712 can go green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up from the discussion on #712.
__tests__/fixtures/malformed/bad.mdstopped being malformed as a side effect of 497ab92 back in April, an unrelated commit whose message says "bad.md fixture corrected to valid markdown", but that file exists specifically to be malformed for these tests. This restores it.Nothing caught the breakage for months because
test-action.ymlonly triggered on changes toaction.yml/scripts/rumdl-action.sh. Added__tests__/fixtures/**and the workflow file itself to thepathsfilters so this class of breakage triggers CI going forward.What's tested:
pull_request(it does)Test Actionjobs pass with both changes combined, including the 4 that were failing on unmodifiedmain(test-args,test-expected-failure,test-combined-informational-with-output,test-output-file-with-violations)