Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor name verification flow #188

Merged
merged 5 commits into from
Sep 26, 2023
Merged

Refactor name verification flow #188

merged 5 commits into from
Sep 26, 2023

Conversation

djc
Copy link
Member

@djc djc commented Sep 24, 2023

Moves code around to reduce coupling and introduce clearer abstractions. Preamble for work on #183.

@codecov
Copy link

codecov bot commented Sep 24, 2023

Codecov Report

Merging #188 (8fef816) into main (12fe2bb) will decrease coverage by 0.03%.
The diff coverage is 93.75%.

@@            Coverage Diff             @@
##             main     #188      +/-   ##
==========================================
- Coverage   96.52%   96.50%   -0.03%     
==========================================
  Files          19       19              
  Lines        4492     4466      -26     
==========================================
- Hits         4336     4310      -26     
  Misses        156      156              
Files Changed Coverage Δ
src/subject_name/dns_name.rs 87.95% <90.47%> (-0.71%) ⬇️
src/subject_name/ip_address.rs 98.29% <94.73%> (-0.09%) ⬇️
src/end_entity.rs 100.00% <100.00%> (ø)
src/subject_name/verify.rs 91.11% <100.00%> (-0.74%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@djc djc changed the title Refactor name verifcation flow Refactor name verification flow Sep 24, 2023
Copy link
Member

@cpu cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@djc djc added this pull request to the merge queue Sep 26, 2023
Merged via the queue into main with commit a7b80a6 Sep 26, 2023
54 of 56 checks passed
@djc djc deleted the name-types-2 branch September 26, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants