Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rsa keypair generation using the rsa crate. #247

Closed
wants to merge 1 commit into from

Conversation

uglyoldbob
Copy link
Contributor

This pull request add capability of generating a 4096 bit keypair using the rsa crate. I wasn't sure how to get the number of bits for the keypair so I assumed 4096.

@cpu
Copy link
Member

cpu commented Mar 18, 2024

Hi there,

We recently added (but haven't released) support for RSA key generation using aws-lc-rs: #230 Does this meet your need?

I suspect there's not much interest in having two different dependencies for this feature, and the rsa crate has at least one unresolved vulnerability at the present time.

@est31
Copy link
Member

est31 commented Mar 18, 2024

I'm not sure they want to fix that vulnerability any time soon, and it's also in a code path that we'd use. I think it's okay to have multiple backends, but the vulnerability is a bit off-putting from integrating the rsa crate directly into rcgen. The rsa-irc example shows how one can use the rsa crate as a rcgen user to generate key pairs for rcgen. It's not that inconvenient.

@est31
Copy link
Member

est31 commented Mar 18, 2024

Thanks for the PR. Closing, will reconsider once RustCrypto/RSA#19 is fixed and released.

@est31 est31 closed this Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants