-
Notifications
You must be signed in to change notification settings - Fork 28
revised divide by zero rule #232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
revised divide by zero rule #232
Conversation
✅ Deploy Preview for scrc-coding-guidelines ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
@felix91gr @PLeVasseur this rule is ready for review. I'm considering removing the duplicate compliant solutions from the required rule and referring to the advisory rule for these to eliminate redundancy. This will hurt readability some, so perhaps we don't want to do this... particularly if we view this as a reference document. |
|
Damn, this is not currently building because the FLS needs updating. I think I'm going to download your fork and build it 'cause if the CI can't build it, it can't produce a preview |
|
@rcseacord you might need to rebase this to get the latest commits. The FLS Ideally |
felix91gr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like your changes a lot. Thanks!
I hope this feedback is useful.
Clarify guideline on integer division and zero divisors
eliminate redundant compliant examples
Co-authored-by: Félix Fischer <[email protected]>
Co-authored-by: Félix Fischer <[email protected]>
Co-authored-by: Félix Fischer <[email protected]>
Co-authored-by: Félix Fischer <[email protected]>
Co-authored-by: Félix Fischer <[email protected]>
Co-authored-by: Félix Fischer <[email protected]>
Co-authored-by: Félix Fischer <[email protected]>
Co-authored-by: Félix Fischer <[email protected]>
Co-authored-by: Félix Fischer <[email protected]>
Co-authored-by: Félix Fischer <[email protected]>
Co-authored-by: Félix Fischer <[email protected]>
some minor edits
de29e0d to
fbdf3b8
Compare
PLeVasseur
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey thanks @rcseacord for revising based on feedback. LGTM, let's merge
AlexCeleste
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved in session on 2025-12-03
Updated the divide by zero rule