Skip to content

Conversation

@rcseacord
Copy link
Collaborator

Updated the divide by zero rule

@netlify
Copy link

netlify bot commented Nov 26, 2025

Deploy Preview for scrc-coding-guidelines ready!

Name Link
🔨 Latest commit fbdf3b8
🔍 Latest deploy log https://app.netlify.com/projects/scrc-coding-guidelines/deploys/6930d15d38401e00084a1df2
😎 Deploy Preview https://deploy-preview-232--scrc-coding-guidelines.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@rcseacord
Copy link
Collaborator Author

@felix91gr @PLeVasseur this rule is ready for review.

I'm considering removing the duplicate compliant solutions from the required rule and referring to the advisory rule for these to eliminate redundancy.

This will hurt readability some, so perhaps we don't want to do this... particularly if we view this as a reference document.

@felix91gr
Copy link
Collaborator

Damn, this is not currently building because the FLS needs updating. I think I'm going to download your fork and build it 'cause if the CI can't build it, it can't produce a preview

@felix91gr
Copy link
Collaborator

@rcseacord you might need to rebase this to get the latest commits. The FLS spec.lock file got updated upstream, and it needs to be up-to-date for the build to pass.

Ideally git should realize that you're not changing the spec.lock file yourself, and simulate applying only the changes you've actually made, but since it cannot do that, I think the only solution is to rebase and fast-forward your changes on top of the latest main commits

Copy link
Collaborator

@felix91gr felix91gr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like your changes a lot. Thanks!

I hope this feedback is useful.

@rcseacord rcseacord requested a review from felix91gr December 3, 2025 23:37
rcseacord and others added 17 commits December 3, 2025 19:05
Clarify guideline on integer division and zero divisors
eliminate redundant compliant examples
some minor edits
@rcseacord rcseacord force-pushed the feat/integer-division branch from de29e0d to fbdf3b8 Compare December 4, 2025 00:10
Copy link
Collaborator

@PLeVasseur PLeVasseur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey thanks @rcseacord for revising based on feedback. LGTM, let's merge

@PLeVasseur PLeVasseur enabled auto-merge December 4, 2025 00:14
@PLeVasseur PLeVasseur disabled auto-merge December 4, 2025 00:14
@PLeVasseur PLeVasseur merged commit 4543086 into rustfoundation:main Dec 4, 2025
6 checks passed
Copy link
Collaborator

@AlexCeleste AlexCeleste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved in session on 2025-12-03

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chapter: expressions coding guideline An issue related to a suggestion for a coding guideline

Development

Successfully merging this pull request may close these issues.

4 participants