Skip to content

Conversation

@MarcosBorgesPhD
Copy link
Contributor

Fix Issue -> PR conversion of tables.

Details

  • Replace deprecated m2r with pypandoc for Markdown -> RST conversion
  • Add Pandoc installation step in auto-pr-on-issue.yml workflow
  • Fix and enhance the Markdown parser for better RST output

Notes

This is PR 3/3 in a series improving Issue -> PR conversion:

  1. PR 1: Fix hyperlinks [Sphinx] [Automation] Make sure Issue -> PR conversion of hyperlinks is correct #221
  2. PR 2: Fix code block conversion [Sphinx] [Automation] Make sure Issue -> PR conversion of code blocks is correct #211
  3. PR 3: Fix table conversion [Sphinx] [Automation] Make sure Issue -> PR conversion of tables is correct #210

Closes #221, #211, #210, #223

@netlify
Copy link

netlify bot commented Nov 20, 2025

Deploy Preview for scrc-coding-guidelines ready!

Name Link
🔨 Latest commit 0b940a0
🔍 Latest deploy log https://app.netlify.com/projects/scrc-coding-guidelines/deploys/69305b954f6fc4000837440f
😎 Deploy Preview https://deploy-preview-228--scrc-coding-guidelines.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@PLeVasseur
Copy link
Collaborator

Thanks for this @MarcosBorgesPhD! I'll try to make time this week to review

MarcosBorgesPhD added a commit to MarcosBorgesPhD/safety-critical-rust-coding-guidelines that referenced this pull request Dec 2, 2025
Pandoc installation is only needed for PR rustfoundation#228, so it has been removed from this branch.
@MarcosBorgesPhD MarcosBorgesPhD force-pushed the pr-210 branch 3 times, most recently from dd7acf1 to 5b4416d Compare December 2, 2025 20:57
@MarcosBorgesPhD
Copy link
Contributor Author

@PLeVasseur Apologies for the extra notifications caused by the history cleanup process.

  1. This branch has been fully rebased onto upstream/main, which should fix the CI failures.

  2. The commit contains only the files relevant to this issue.

MarcosBorgesPhD added a commit to MarcosBorgesPhD/safety-critical-rust-coding-guidelines that referenced this pull request Dec 2, 2025
Pandoc installation is only needed for PR rustfoundation#228, so it has been removed from this branch.
@plaindocs
Copy link
Collaborator

Thanks @MarcosBorgesPhD , would you mind removing the uv.lock and addressing the merge conflict then I think this should be good to go.

@MarcosBorgesPhD
Copy link
Contributor Author

@plaindocs wow it's going to be merged today! Removing uv.lock right now. Thank you

This branch has been rebased onto the latest upstream/main to integrate recent dependency fixes (spec.lock update) and fix CI failures.

The history has been cleaned to contain only the changes relevant to this feature.
MarcosBorgesPhD added a commit to MarcosBorgesPhD/safety-critical-rust-coding-guidelines that referenced this pull request Dec 3, 2025
rustfoundation#221 (rustfoundation#226)

* Fix: Normalize Markdown links and formatting

- Convert inline-code links like [`text`](url) to standard [text](url)
- Correct mixed bold/code formatting:
    - **`code`** → `code`
    - `**code**` → `code`

This prevents Markdown parser errors in issue bodies and ensures consistent formatting.

* Fix: address CI failure by updating snapshot-ci.yml

* Fix: address CI failure by updating Pandoc installation

* Remove parts requested by @plaindocs

Pandoc installation is only needed for PR rustfoundation#228, so it has been removed from this branch.
Copy link
Collaborator

@plaindocs plaindocs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the extra steps.

You can avoid the merge conflicts in future by making cleaner PRs by branching off main for each new PR, instead of off the last branch.

Apreciate your work on this.

@plaindocs plaindocs added this pull request to the merge queue Dec 3, 2025
Merged via the queue into rustfoundation:main with commit bfad9e1 Dec 3, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Sphinx] [Automation] Make sure Issue -> PR conversion of hyperlinks is correct

3 participants