Configure cargo-all-features for CI to drop xen-specific custom tests #352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roypat
requested review from
alexandruag,
bonzini,
jiangliu and
ShadowCurse
as code owners
Pick up the test changes to enable cargo-all-features Signed-off-by: Patrick Roy <[email protected]>
Now that the normal CI does cargo all-features [test|build], there is no longer a need to have separate buildkite steps just for the xen-disabled usecase. Signed-off-by: Patrick Roy <[email protected]>
Skip explicitly adding optional dependencies to the permutation matrix (e.g. for example testing with --no-default-features, but the vmm-sys-util optional dependency enabled anyway), as this does not seem very useful (there is no way for a downstream to ever actually use this configuration). Signed-off-by: Patrick Roy <[email protected]>
Without that feature, we do not have ReadVolatile/WriteVolatile impls for File, which the benches depend on. Signed-off-by: Patrick Roy <[email protected]>
Signed-off-by: Patrick Roy <[email protected]>
roypat
force-pushed
the
cargo-all-features
branch
2 times, most recently
from
cd6b96b to
629cde9
Compare
ShadowCurse
approved these changes
Oct 1, 2025
rbradford
approved these changes
Oct 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the PR
With rust-vmm/rust-vmm-ci#192 switching our default tests to use cargo-all-features, we no longer need special test steps in custom-tests.json to work around the non-additive nature of the xen feature.
Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s), and the commit message has max 60 characters for thesummary and max 75 characters for each description line.
test.
Release" section of CHANGELOG.md (if no such section exists, please create one).
unsafecode is properly documented.