Use --ignore-rust-version on non-MSRV builds #1672
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhardy
commented
Oct 20, 2025
Comment on lines
88
to
90
| - name: MSRV | ||
| if: ${{ matrix.variant == 'MSRV' }} | ||
| run: cp Cargo.lock.msrv Cargo.lock | ||
| if: ${{ matrix.variant != 'MSRV' }} | ||
| run: cargo generate-lockfile --ignore-rust-version |
There was a problem hiding this comment.
Feels strange to do it this way, but I think it does what we want: test the latest possible dependencies except in the MSRV build.
There was a problem hiding this comment.
You probably should modify name of the step.
newpavlov
approved these changes
Oct 20, 2025
dhardy
force-pushed
the
push-nrwwpuwzpouy
branch
from
5df9c01 to
15e9e23
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes
Cargo.lock.msrvand updates CI jobs. See conversation after #1668 was merged.