Implement base for PCI Root bridge io protocols #1724
Conversation
|
|
||
| impl Drop for PciMappedRegion<'_, '_> { | ||
| fn drop(&mut self) { | ||
| let status = unsafe { (self.proto.unmap)(self.proto, self.key) }; |
There was a problem hiding this comment.
Would it make sense to add a fn unmap(self) -> Result method, so that callers can choose to handle errors from unmapping? The Drop trait doesn't really allow that. I think the drop implementation should probably not panic on errors, and that we should remove the unreachable; UEFI implementations sometimes return additional errors beyond what the spec includes.
Ditto for the PciPage implementation.
There was a problem hiding this comment.
True, I initially put unreachable macro there to indicate that "errors that may happen according to spec are all handled and no other error can occur"
But yeah second thought we can never be sure
There was a problem hiding this comment.
Tho, what else should it do when an error occurs? Should I make it undroppable(assuming it's possible) so that users must use functions like unmap?
|
Well test fails on windows because it can't use new pci memory device |
This is continuation of #1705
As requested by @phil-opp I decided to split the pr into multiple.
This one only contains base for the upcoming other PRs.
Specifically, it contains wrapper for pages allocated and regions mapped by the protocol.
and it adds new pci device with big memory for testing memory protocols later.
Since no protocol is submitted yet users wont be able to use this for now.
Checklist