Improve and simplify commands errors #2192
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to fought today to find the error in rust-lang/rustup#2876 (comment), mainly because CloudWatch is really bad, but also because we didn't post any error to the user.
This PR improves the way we deal with user facing error by creating a
inform!
macro that wrapsanyhow::bail!
+UserError
. This allows two things, first that we always post an error message to the user and second that we log it (correctly).This has also the side-effect that don't return 500 when we only have user facing errors. It also reduce the boilerplate of doing
ErrorComment
+post()
+return Ok(())
each time.To put it in another way, let's use our the
HandlerError
infra the way it should be used.