Add Nix flake #2179
Open
Add Nix flake #2179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is required for building `openssl-sys` on NixOS
|
Would the nix flake still be required if we were to use |
|
Indeed not. I wanted to suggest something like that as well, but wasn't sure how much work that would be |
|
Then feel free to send a PR switching to rustls. |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I wanted to make some small contributions, but couldn't build the crate because of the problem with
openssl-syson NixOS: sfackler/rust-openssl#1663.So I added a Nix dev-shell (
flake.nix) with all the required dependencies and envvars, and while I could just use that locally, I figured it could be useful for other NixOS users, so here's a PR to put that in the repo.The
flake.nixitself should really require no maintenance;flake.lockcan be bumped from time to time (usingnix flake update), but that's not strictly necessary for a one-off contribution, so up to you.I also added myself as the codeowner for flake files in order to take care of eventual PRs (which I, again, don't expect too many of).