Skip to content

Migrate to axum and hyper 1 🎉 #2134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Aug 5, 2025
Merged

Migrate to axum and hyper 1 🎉 #2134

merged 14 commits into from
Aug 5, 2025

Conversation

Urgau
Copy link
Member

@Urgau Urgau commented Aug 2, 2025

This PR migrates triagebot endpoints to axum (0.8) and hyper (1.6) 🎉

In the process we clean up some things, add compression of responses, add catch panic, make use of axum types when possible (Json, Path, ...) and simplify a bunch of logic.

I tested what I could locally, but more testing is probably required.

cc @ehuss @Mark-Simulacrum @GuillaumeGomez

@Urgau Urgau requested a review from Kobzol August 2, 2025 21:14
@Kobzol
Copy link
Member

Kobzol commented Aug 4, 2025

This is awesome ❤️ Thanks so much for working on it. I don't have any further comments about the code, other than http_body_util seems to be unused?

@Urgau
Copy link
Member Author

Urgau commented Aug 4, 2025

http_body_util seems to be unused?

Yeah, it's not used directly by triagebot, removed it.

@Urgau Urgau added this pull request to the merge queue Aug 5, 2025
Merged via the queue into rust-lang:master with commit a66fe51 Aug 5, 2025
3 checks passed
@Urgau Urgau deleted the axum branch August 5, 2025 18:47
@Urgau
Copy link
Member Author

Urgau commented Aug 5, 2025

@rustbot label +enhancement

@rustbot rustbot added the enhancement New feature or request label Aug 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants