Don't panic when there is no zulip token #1767
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackh726
reviewed
Feb 21, 2024
There was a problem hiding this comment.
Don't really like the indentation changes here. Can probably make this a bit cleaner by either splitting the inner bits into new functions, or moving the logic further up.
I do like the ZulipContext change though, happy to review that separately if you want to get that landed.
|
@WaffleLapkin, still interested in this change? If so, can you address Jack comment. |
|
@Urgau no, not really. Feel free to take these changes if you want. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
triagebot currently uses
env::var().unwrap()inside code that handles zulip things, which is not ideal (and leads to panics spamming logs for people like me, who run triagebot themselves).I'm not happy with this PR, but it probably solves the issue...
Ideally there would be a better system for enabling/disabling subsystems for the bot (via a per-instance-config and/or env vars), but I do not have energy to work on anything like that.