Revert pull_request field change. #1653
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mark-Simulacrum
approved these changes
Sep 11, 2022
|
For future notice, should this codepath will be changed: #1646 also was breaking the T-compiler agenda generation (specifically commit 3cde23d) when running the triagebot command Just mentioning this because some dependencies are not always apparent with this codebase. A good strategy could be to run all three CLI binaries of the triagebot ( Anyway, no problem, this patch reverts the breaking change :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change to the
pull_requestfield in #1646 is causing way more trouble than it is worth. If GitHub sometimes populates this field, then it is useful to know if it is a pull request or not.Fixes #1651.