-
Notifications
You must be signed in to change notification settings - Fork 288
Check cfg on features that stage0 compiler support #1798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Since the bootstrap compiler of Rust is bumped to the commit 5dadfd5c417f0b66816cb7ca662859e2c8751fb3 (version 1.88.0-beta.3 2025-05-11), some features should be safe to enable cfg checks. RISC-V Features: * "zicsr" * "zicntr" * "zihpm" * "zifencei" * "zihintntl" * "zihintpause" * "zimop" * "zicboz" * "zicond" * "ztso" * "zfa" * "zca" * "zcb" * "zcmop" * "b" x86 Features: * "amx-avx512" * "amx-fp8" * "amx-movrs" * "amx-tf32" * "amx-transpose"
@sayantn A link to a CI failure (e.g. a comment by a bot) will be very helpful for me. |
That is quite interesting, I honestly have no idea why it did work as intended. Also, I think there were some changes to the rustc bootstrapping procedure lately, as I have noticed a little on the T-infra zulip streams 😅. You are sure that |
@sayantn After I mentioned you, I finally managed to break the CI by adding an unknown feature without |
Rust's CI jobs Note: due to a possible bug, I had to run Docker images in the interactive mode SCRIPT=/tmp/stage_2_test_set1.sh /checkout/src/ci/run.sh && \
SCRIPT=/tmp/x86_64-gnu-llvm2.sh /checkout/src/ci/run.sh && \
SCRIPT=/tmp/x86_64-gnu-llvm3.sh /checkout/src/ci/run.sh |
That is extremely weird, could you mention it in the T-compiler zulip so that someone more experienced can step in |
Since the bootstrap compiler of Rust is bumped to the commit rust-lang/rust@5dadfd5 (version 1.88.0-beta.3 2025-05-11), some features should be safe to enable
cfg
checks.This is a superset of the revert of #1768.
RISC-V Features:
x86 Features: