-
Notifications
You must be signed in to change notification settings - Fork 263
Add support for Windows Registered I/O #604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more change then it LGTM
No, because that is used with the |
I don't get it sorry. Also I put the new function with the all feature flag too, should I remove it? |
@DBLouis you need to revert all changes to |
That makes sense. So I revert the changes for no_inherit, but for registered-io I keep only one function. Should it be feature gated though? It is a windows only flag and a bit niche. |
That's exactly why it should be feature gated. |
Is it all good now? Please tell me if it needs more work :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Can you add a test for this? I don't know if there is a way to retrieve if the flag is set, but at the very least I'll like a test that ensure the setting doesn't error.
This allows to create socket with the
WSA_FLAG_REGISTERED_IO
flag.