chore(deps): update opentelemetry #4199
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #4182.
Following #4182 (comment), I realized that since
otel
is not an essential part of our project (it's used in benchmarks for the timeline view only), the following change has brought us no benefits:... so it'd be nice to just stick to the original behavior of
shutdown_tracer_provider()
, which is simply replacing the global tracer provider withNoopTracerProvider::new()
and dropping the replaced provider immediately:https://github.com/open-telemetry/opentelemetry-rust/blob/99d24b7b8ca25652b955678a1109af0f9d65e242/opentelemetry/src/global/trace.rs#L398-L430
Regarding the setup/shutdown ergonomics, I've made a simple guard to bring back
(before|after)_test_async()
with minimal efforts, so this has also addressed the test-related part of #4195, although it'd probably still be nice to be able to fetch e.g. logger filter levels directly from withinProcess
, so the remainder of that issue stays valid.