refactor rewrite_literal & combine_strs_with_missing_comments #6250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
41 tasks
ding-young
commented
Jul 26, 2024
ding-young
commented
Jul 29, 2024
Comment on lines
2148
to
+2151
| let shape = if contains_comment { | ||
| shape.block_left(context.config.tab_spaces())? | ||
| shape | ||
| .block_left(context.config.tab_spaces()) | ||
| .max_width_error(shape.width, between_span.with_hi(ex.span().hi()))? |
There was a problem hiding this comment.
... = // comment
ExprSince between_span corresponds to the span of // comment but we are calculating the shape for the expr, I think the span for max_width_error should start from between_span.lo() and end with expr.span.hi()
ytmimi
reviewed
Jul 31, 2024
src/chains.rs
Outdated
| @@ -267,8 +267,15 @@ impl ChainItemKind { | |||
| } | |||
|
|
|||
| impl Rewrite for ChainItem { | |||
| // TODO impl rewrite_result after rebase | |||
There was a problem hiding this comment.
Just wondering what this comment is referencing. Can this be removed?
There was a problem hiding this comment.
Sure, since this pr also implements rewrite_result for ChainItem, I removed the comment.
ytmimi
approved these changes
Aug 3, 2024
There was a problem hiding this comment.
Thank you for another rewrite_result PR. Running the Diff-Check Job now
Edit: Job passed ✅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracked by #6206
Description
combine_strs_with_missing_commentsand its call sites