-
Notifications
You must be signed in to change notification settings - Fork 925
return RewriteResult for rewrite_path & rewrite_struct_*** #6236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for another PR. This one is next on my todo list |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we're good to go on this one. We just need to address the merge conflict
- refactor rewrite_*** functions that call rewrite_path to return RewriteResult - modify rewrite_aligned_item method of AlignedItem
67d69e0
to
fe9b50a
Compare
Running the Diff-Check Job now Edit: The job passed ✅ |
Just noting that this broader change (not specifically this PR, but the overall mission of #6206, has a higher chance of causing merge conflicts on the subtree syncs so if possible it would be good to try to get some more frequent syncs through |
@calebcartwright Thanks for pointing that out. I'll try to follow your advice :) |
nothing for you to worry about @ding-young, it was mostly a note to myself & Yacin to try to get these in more frequently |
@calebcartwright good call out. I don't think there's been many changes in |
Tracked by #6206
Description
Modify following functions to return
RewriteResult
Impl rewrite_result for
PreciseCapturingArg
,AssocItemConstraint
,PolyTraitRef
,TraitRef
in types.rs(These are the nodes that were waiting for certain rewrite_*** to return RewriteResult. see #6220)
Side notes
Option<String>
since it is used for the possible range of width for struct prefix (see struct_field_prefix_max_min_width)unknown_error()
calls since I haven't modifiedwrite_list
,itemize_list
, and similar functions. There's ongoing concern about modifying these functions and the iterator implementation forListItems
.