Separate a comparisons table component and use it in compile and runtime tabs #1672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would still be glad for your opinion, but on second thought, maybe this is just forcing an abstraction where it doesn't belong and we shouldn't do this. If we wanted to add new complex behavior to the individual tables (and I have some ideas here), then it would be quite complicated to keep this as a unifie component. |
|
We can keep them separate to allow for parallel evolution until we know it would be helpful to regroup them: if we ever have to add features to a common core a few times, then we'd add the abstraction less prematurely and reduce duplication. |
|
I agree. Closing this for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring to reduce the amount of duplicated code in the compare page.