Add artifact size UI to compare page #1658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It would be very helpful if there could be tooltips or something similar with brief explanations of each component. |
|
Good point, I added a short tooltip to each known artifact in the table. |
Kobzol
force-pushed
the
artifact-size-ui
branch
2 times, most recently
from
96c1f12
to
e523777
Compare
lqd
reviewed
Jul 26, 2023
site/frontend/src/pages/compare/artifact-size/artifact-size-table.vue
Outdated
Show resolved
Hide resolved
site/frontend/src/pages/compare/artifact-size/artifact-size-table.vue
Outdated
Show resolved
Hide resolved
site/frontend/src/pages/compare/artifact-size/artifact-size-table.vue
Outdated
Show resolved
Hide resolved
site/frontend/src/pages/compare/artifact-size/artifact-size-table.vue
Outdated
Show resolved
Hide resolved
site/frontend/src/pages/compare/artifact-size/artifact-size-table.vue
Outdated
Show resolved
Hide resolved
lqd
reviewed
Jul 27, 2023
site/frontend/src/pages/compare/artifact-size/artifact-size-table.vue
Outdated
Show resolved
Hide resolved
lqd
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a tab with a simple table containing artifact component size diff to the compare page.