Adjust some doc for Query System #2465
Conversation
|
Thanks for the PR. If you have write access, feel free to merge this PR if it does not need reviews. You can request a review using |
rustbot
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
Signed-off-by: xizheyin <[email protected]>
|
r? rustc-dev-guide |
| [`wasm_import_module_map`][wasm_import_module_map], that `rustc_driver` can invoke. | ||
| 1. Implement the provider function: | ||
| ```rust,ignore | ||
| fn fubar<'tcx>(tcx: TyCtxt<'tcx>, key: DefId) -> Fubar<'tcx> { ... } |
There was a problem hiding this comment.
will do this change in a future pr
| fn fubar<'tcx>(tcx: TyCtxt<'tcx>, key: DefId) -> Fubar<'tcx> { ... } | |
| fn fubar<'tcx>(tcx: TyCtxt<'tcx>, key: LocalDefId) -> Fubar<'tcx> { ... } |
There was a problem hiding this comment.
oh, I see we now have ExternProvider as well (since rust-lang/rust#85830)... would you be able to adjust docs to account for it @xizheyin
There was a problem hiding this comment.
No problem, I'm just working on this pr rust-lang/rust#142450, which involves extern providers.
There was a problem hiding this comment.
alright... feel free to modify rdg there as well, to avoid having to open a separate pr here
There was a problem hiding this comment.
I thought the changes to rdg could only be made here. It seems that I can submit other improvements in rust-lang/rust in the future.
But for this improvement, I think it would be better to submit it here, because rust-lang/rust may take time to synchronize.
This PR improves the documentation for the rustc query system.
Providers