-
Notifications
You must be signed in to change notification settings - Fork 13.3k
mark raw_vec::ptr with inline #79113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
(rust_highfive has picked a reviewer for you, use r? to override) |
@bors try @rust-timer queue |
Awaiting bors try build completion |
⌛ Trying commit 88d1f31 with merge 35e31b36ab0b88482a02d490af328f51852bf292... |
☀️ Try build successful - checks-actions |
Queued 35e31b36ab0b88482a02d490af328f51852bf292 with parent f5230fb, future comparison URL. |
Finished benchmarking try commit (35e31b36ab0b88482a02d490af328f51852bf292): comparison url. Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up. @bors rollup=never |
a bit unfortunate increase for syn (what I can see that crate contains a lot of vec:s of the same type) but otherwise the perf looks ok. on the other hand this PR is maybe more a band-aid for this specific benchmark then a fix for the real problem. |
@joshtriplett what do you think close or not? |
@bors r+ rollup |
📌 Commit 88d1f31 has been approved by |
@bors rollup=never Has perf impact |
☀️ Test successful - checks-actions |
when a lot of vectors is used in a enum as in the example in #66617 if this function is not inlined and multiple cgus is used this results in huge compile times. with this fix the compile time is 6s from minutes for the example in #66617. I did not have the patience to wait for it to compile for more then 3 min.