Skip to content

Update jemalloc to 4.0.3 #29196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Update jemalloc to 4.0.3 #29196

wants to merge 1 commit into from

Conversation

fbernier
Copy link
Contributor

Updating to 4.0.0 had already been attempted here, but for some reasons the tests failed. I just tried with the latest jemalloc release and they seemed to work (if I am doing this right).

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@fbernier
Copy link
Contributor Author

So, I am not sure it's going to build finally. it looks like jemalloc 4.0.3 doesn't ship with a configure script and it has to be generated with autoconf, but configure is in the .gitignore. I don't really know what to do with this yet.

@fbernier
Copy link
Contributor Author

and rust-lang/jemalloc would need to be updated. I guess I should not be doing this as it looks like this whole job should be made by someone from the core team. Sorry for the noise.

@fbernier fbernier closed this Oct 21, 2015
@alexcrichton
Copy link
Member

@fbernier ah I'm totally fine trying out the update again! You'll want to open a PR against rust-lang/jemalloc, and yeah you'll basically use the relevant commit of upstream jemalloc and then add one with a checked in configure script on top. I'll merge after that and then a PR can be made here

@fbernier
Copy link
Contributor Author

Great! Will do that soon. Thanks!

Manishearth added a commit to Manishearth/rust that referenced this pull request Oct 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants