Feed constness in def collection#158305
Conversation
… instead of ast lowering
|
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…try> Feed constness in def collection
This comment has been minimized.
This comment has been minimized.
|
Finished benchmarking commit (3618539): comparison URL. Overall result: ❌ regressions - please read:Benchmarking means the PR may be perf-sensitive. It's automatically marked not fit for rolling up. Overriding is possible but disadvised: it risks changing compiler perf. Next, please: If you can, justify the regressions found in this try perf run in writing along with @bors rollup=never Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary 1.1%, secondary -1.0%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (secondary -3.8%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeResults (secondary -0.1%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Bootstrap: 504.341s -> 504.7s (0.07%) |
Not all constnesses are fed, e.g. delegations can't be known at this stage.
This is an attempt at resolving part of the perf regression from #157647 (comment), which mostly happens in incremental because the constness query needs to load the HIR
r? @ghost