Skip to content

Conversation

@Kobzol
Copy link
Member

@Kobzol Kobzol commented Jan 7, 2026

Successful merges:

r? @ghost

Create a similar rollup

Urgau and others added 10 commits January 6, 2026 23:02
Factorize `triagebot.toml` float parsing mentions with a glob matching

Related to rust-lang/triagebot#2244.

r? @tgross35
Convert static lifetime to an nll var

Fixes rust-lang#150648

I don't think this matters for any non 'static lifetimes as defining the struct as `Wrap<'a>` would mean the lifetime argument gets replaced with an nll var before MIR type checking meaning the struct tail is `dyn Trait + '?x`

r? types
Move issue-12660 to 'ui/cross-crate/ with a descriptive name

Author: Immad Mir <[email protected]>
@rust-bors rust-bors bot added the rollup A PR which is a rollup label Jan 7, 2026
@rustbot rustbot added A-meta Area: Issues & PRs about the rust-lang/rust repository itself A-tidy Area: The tidy tool S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 7, 2026
@Kobzol
Copy link
Member Author

Kobzol commented Jan 7, 2026

@bors r+ rollup=never p=5

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 7, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 7, 2026

📌 Commit beb734b has been approved by Kobzol

It is now in the queue for this repository.

@rust-bors

This comment has been minimized.

@rust-bors rust-bors bot added the merged-by-bors This PR was explicitly merged by bors. label Jan 8, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 8, 2026

☀️ Test successful - CI
Approved by: Kobzol
Pushing 548e586 to main...

@rust-bors rust-bors bot merged commit 548e586 into rust-lang:main Jan 8, 2026
12 checks passed
@rustbot rustbot added this to the 1.94.0 milestone Jan 8, 2026
@rust-timer
Copy link
Collaborator

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#150738 Factorize triagebot.toml float parsing mentions with a gl… cdf24a16e57521402356ab00272dc93b43e4c555 (link)
#150761 rustc book: fix grammar 89d4b1b09cfd05d9a33d0a5ce7466f30586f4893 (link)
#150764 Convert static lifetime to an nll var a56d4c2b05c6611ae289a1dfcdebfa3f3a7873fd (link)
#150775 Move issue-12660 to 'ui/cross-crate/ with a descriptive name 50f512eb8c0e5f55d9aa1da86903201212300c20 (link)

previous master: fecb335cba

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)
     Running `target/release/citool post-merge-report 548e586795f6b6fe089d8329aa5edbf0f5202646`
error: the following required arguments were not provided:
  <CURRENT>

Usage: citool post-merge-report <PARENT> <CURRENT>

For more information, try '--help'.
##[error]Process completed with exit code 2.
Post job cleanup.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (548e586): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.0% [0.0%, 0.0%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (secondary 2.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.7% [2.7%, 2.7%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Cycles

Results (secondary 1.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
4.9% [4.9%, 4.9%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-2.5% [-2.5%, -2.5%] 1
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 473.64s -> 474.664s (0.22%)
Artifact size: 390.86 MiB -> 390.87 MiB (0.00%)

@Kobzol Kobzol deleted the rollup-0mvdoy5 branch January 8, 2026 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-meta Area: Issues & PRs about the rust-lang/rust repository itself A-tidy Area: The tidy tool merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants