-
-
Notifications
You must be signed in to change notification settings - Fork 14.3k
Rollup of 4 pull requests #150784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 4 pull requests #150784
Conversation
Author: Immad Mir <[email protected]>
Factorize `triagebot.toml` float parsing mentions with a glob matching Related to rust-lang/triagebot#2244. r? @tgross35
rustc book: fix grammar
Convert static lifetime to an nll var Fixes rust-lang#150648 I don't think this matters for any non 'static lifetimes as defining the struct as `Wrap<'a>` would mean the lifetime argument gets replaced with an nll var before MIR type checking meaning the struct tail is `dyn Trait + '?x` r? types
Move issue-12660 to 'ui/cross-crate/ with a descriptive name Author: Immad Mir <[email protected]>
|
@bors r+ rollup=never p=5 |
This comment has been minimized.
This comment has been minimized.
|
📌 Perf builds for each rolled up PR:
previous master: fecb335cba In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
|
A job failed! Check out the build log: (web) (plain enhanced) (plain) Click to see the possible cause of the failure (guessed by this bot) |
|
Finished benchmarking commit (548e586): comparison URL. Overall result: ❌ regressions - no action needed@rustbot label: -perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (secondary 2.7%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (secondary 1.2%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 473.64s -> 474.664s (0.22%) |
Successful merges:
triagebot.tomlfloat parsing mentions with a glob matching #150738 (Factorizetriagebot.tomlfloat parsing mentions with a glob matching)r? @ghost
Create a similar rollup