-
Notifications
You must be signed in to change notification settings - Fork 13.8k
std::os::windows::net: add Unix-domain socket support (AF_UNIX on Windows) #147335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kouhe3
wants to merge
8
commits into
rust-lang:master
Choose a base branch
from
kouhe3:win-af-unix
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+384
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
☔ The latest upstream changes (presumably #147340) made this pull request unmergeable. Please resolve the merge conflicts. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
O-windows
Operating system: Windows
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? rust-lang/libs-api
Summary
This PR adds Unix-domain socket support to the Windows port of the standard library,
mirroring the existing APIs in
std::os::unix::net
.The implementation is gated behind the unstable feature
windows_unix_domain_sockets
;track issue #56533 .
Motivation / Background
Windows 10 17063+ officially support AF_UNIX.
Having the same
UnixStream
/UnixListener
surface on Windows removes the need forcrates such as
mio-uds-windows
and lets cross-platform code use a single API.Acknowledgements
most of the code was transplanted from
https://github.com/Azure/mio-uds-windows
(thank you @damonbarry ).
The main delta is switching from the
winapi
crate to thestd
.What is added
std::os::windows::net
UnixStream
,UnixListener
,SocketAddr
,sockaddr_un
All types mirror their Unix counterparts and implement the usual
Read+Write
,AsRawSocket/FromRawSocket/IntoRawSocket
,AsSocket
, etc.Feature gate
Testing
Can't run test because rustc ICE
How to try it locally
Notes for reviewers
sys::pal::windows
.unsafe
is restricted toWSASocketW
,bind
,connect
,getsockname
,getpeername
.sockaddr_un
construction follows the Unix implementation: zero-init, copy path, null-term.Drop
impl is reused fromsys::net::Socket
, soclosesocket
always runs.Commit message
Checklist before clicking “Create pull request”
./x.py fmt
- clean./x.py test
- passed