Skip to content

[beta] backports #147284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 8, 2025
Merged

[beta] backports #147284

merged 7 commits into from
Oct 8, 2025

Conversation

@cuviper
Copy link
Member

@cuviper cuviper commented Oct 2, 2025 •
edited
Loading

r? cuviper

lcnr added 3 commits October 2, 2025 16:20
@lcnr @cuviper
yeet fastpath
b664386 
(cherry picked from commit 4fcafc9)
@lcnr @cuviper
remove test for no_core
dad01bc 
(cherry picked from commit 83532f8)
@lcnr @cuviper
add test
34182f6 
(cherry picked from commit 7a0adc0)
@rustbot rustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Oct 2, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 2, 2025

⚠️ Warning ⚠️

@cuviper
Copy link
Member Author

cuviper commented Oct 3, 2025

@bors r+ p=1 rollup=never

@bors
Copy link
Collaborator

bors commented Oct 3, 2025

📌 Commit 98e2fd3 has been approved by cuviper

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 3, 2025
bors added a commit that referenced this pull request Oct 3, 2025
@bors
Auto merge of #147284 - cuviper:beta-next, r=cuviper
93b26c2 
[beta] backports

- remove incorrect fast path #146919
- Update LLVM to 21.1.2 #146953
- Fix infinite recursion in Path::eq with String #146958

r? cuviper
@bors
Copy link
Collaborator

bors commented Oct 3, 2025

⌛ Testing commit 98e2fd3 with merge 93b26c2...

@bors
Copy link
Collaborator

bors commented Oct 3, 2025

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 3, 2025
@hkBst
Copy link
Member

hkBst commented Oct 3, 2025

fails with: System.IO.IOException: No space left on device : '/home/runner/actions-runner/cached/_diag/Worker_20251003-040227-utc.log'

@cuviper
Copy link
Member Author

cuviper commented Oct 3, 2025

Hmm, I don't see any CI changes on master for that kind of error -- maybe it was spurious?

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 3, 2025
bors added a commit that referenced this pull request Oct 3, 2025
@bors
Auto merge of #147284 - cuviper:beta-next, r=cuviper
12b7c51 
[beta] backports

- remove incorrect fast path #146919
- Update LLVM to 21.1.2 #146953
- Fix infinite recursion in Path::eq with String #146958

r? cuviper
@bors
Copy link
Collaborator

bors commented Oct 3, 2025

⌛ Testing commit 98e2fd3 with merge 12b7c51...

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Collaborator

bors commented Oct 4, 2025

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 4, 2025
@cuviper
Copy link
Member Author

cuviper commented Oct 4, 2025

@bors retry

@bors bors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 4, 2025
@bors bors added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 6, 2025
@cuviper
Copy link
Member Author

cuviper commented Oct 6, 2025

Well 3-in-a-row is pretty clearly busted -- but this time the message makes it clear that ld is really rust-lld, so this could be related to the LLVM upgrade somehow.

cc @rust-lang/wg-llvm

@dianqk
Copy link
Member

dianqk commented Oct 7, 2025

@bors try jobs=x86_64-gnu-distcheck

rust-bors bot added a commit that referenced this pull request Oct 7, 2025
@rust-bors
Auto merge of #147284 - cuviper:beta-next, r=<try>
5e62eab 
[beta] backports

try-job: x86_64-gnu-distcheck
@rust-bors

This comment has been minimized.

Sign in to view
@rust-bors
Copy link

rust-bors bot commented Oct 7, 2025

💔 Test for 5e62eab failed: CI. Failed jobs:

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@cuviper
Copy link
Member Author

cuviper commented Oct 7, 2025

Trying without the LLVM update:

@bors try jobs=x86_64-gnu-distcheck

rust-bors bot added a commit that referenced this pull request Oct 7, 2025
@rust-bors
Auto merge of #147284 - cuviper:beta-next, r=<try>
74f2a49 
[beta] backports

try-job: x86_64-gnu-distcheck
@rust-bors

This comment has been minimized.

Sign in to view
@rust-bors
Copy link

rust-bors bot commented Oct 8, 2025

☀️ Try build successful (CI)
Build commit: 74f2a49 (74f2a496fe66118ac4158e52509b67c22abb4536, parent: aa7859c0dec2de6c9cab34b03028bcef7b1fc25d)

@cuviper
Copy link
Member Author

cuviper commented Oct 8, 2025

@bors r+

@bors
Copy link
Collaborator

bors commented Oct 8, 2025

📌 Commit 0d2b92c has been approved by cuviper

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 8, 2025
@bors
Copy link
Collaborator

bors commented Oct 8, 2025

⌛ Testing commit 0d2b92c with merge 21cd82a...

@bors
Copy link
Collaborator

bors commented Oct 8, 2025

☀️ Test successful - checks-actions
Approved by: cuviper
Pushing 21cd82a to beta...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 8, 2025
@bors bors merged commit 21cd82a into rust-lang:beta Oct 8, 2025
12 checks passed
@rustbot rustbot added this to the 1.91.0 milestone Oct 8, 2025
@nikic
Copy link
Contributor

nikic commented Oct 8, 2025

I was able to reproduce the crash in a local docker run yesterday, but when I tried again today (on the same commit, with the LLVM update included) it worked :(

@dianqk
Copy link
Member

dianqk commented Oct 9, 2025

I guess this is due to the task running out of disk space. I got the same crash in #147463 (comment), but I didn't change any code in LLVM.

@nikic
Copy link
Contributor

nikic commented Oct 9, 2025

Oh, that explains what happened during my local test as well. I did run out of disk space between the two runs and cleaned up the volume, but didn't make the connection that it could be the cause of the crash.

@dianqk dianqk mentioned this pull request Oct 10, 2025
Closed
@cuviper cuviper mentioned this pull request Oct 22, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@cuviper cuviper

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.91.0

Development

Successfully merging this pull request may close these issues.