[TOY] Run MIR opts before coroutine state transform

[cjgillot]

r? @ghost

[cjgillot]

@bors try

[rust-bors]

☀️ Try build successful (CI)
Build commit: b6ae10a (b6ae10aa7319b7ebb6c7b3331dd71a9d6c9c5b4b, parent: 350d0ef0ec0493e6d21cfb265cb8211a0e74d766)

[cjgillot]

@rust-timer queue

[lqd]

@rust-timer build b6ae10a

[rust-timer]

Finished benchmarking commit (b6ae10a): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @rustbot label: +perf-regression-triaged. If not, please fix the regressions and do another perf run. If its results are neutral or positive, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	0.2%	[0.2%, 0.3%]	3
Regressions ❌ (secondary)	3.0%	[0.5%, 8.5%]	8
Improvements ✅ (primary)	-0.3%	[-1.2%, -0.1%]	11
Improvements ✅ (secondary)	-1.6%	[-4.4%, -0.2%]	16
All ❌✅ (primary)	-0.2%	[-1.2%, 0.3%]	14

Max RSS (memory usage)

Results (primary -2.4%, secondary 0.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	1.0%	[0.9%, 1.1%]	2
Regressions ❌ (secondary)	2.3%	[1.5%, 2.9%]	4
Improvements ✅ (primary)	-9.2%	[-9.2%, -9.2%]	1
Improvements ✅ (secondary)	-2.5%	[-2.5%, -2.4%]	2
All ❌✅ (primary)	-2.4%	[-9.2%, 1.1%]	3

Cycles

Results (secondary -0.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	4.1%	[2.0%, 5.3%]	3
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.9%	[-4.1%, -1.6%]	6
All ❌✅ (primary)	-	-	0

Binary size

Results (primary 0.0%, secondary 2.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	0.1%	[0.1%, 0.1%]	4
Regressions ❌ (secondary)	6.4%	[0.1%, 18.3%]	18
Improvements ✅ (primary)	-0.0%	[-0.0%, -0.0%]	6
Improvements ✅ (secondary)	-0.4%	[-6.3%, -0.0%]	19
All ❌✅ (primary)	0.0%	[-0.0%, 0.1%]	10

Bootstrap: 468.291s -> 467.628s (-0.14%)
Artifact size: 377.36 MiB -> 377.38 MiB (0.00%)

[bors]

☔ The latest upstream changes (presumably #145600) made this pull request unmergeable. Please resolve the merge conflicts.

[bors]

☔ The latest upstream changes (presumably #145916) made this pull request unmergeable. Please resolve the merge conflicts.

[bors]

☔ The latest upstream changes (presumably #146666) made this pull request unmergeable. Please resolve the merge conflicts.

[cjgillot]

Let's try to discover miscompilations:
@craterbot run mode=build-and-test

[craterbot]

👌 Experiment pr-145330 created and queued.
🤖 Automatically detected try build b6ae10a
⚠️ Try build based on commit 0be736b, but latest commit is 5c25cff. Did you forget to make a new try build?
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

[craterbot]

🚧 Experiment pr-145330 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

[craterbot]

🎉 Experiment pr-145330 is completed!
📊 255 regressed and 166 fixed (703555 total)
📊 119132 spurious results on the retry-regessed-list.txt, consider a retry¹ if this is a significant amount.
📰 Open the summary report.

⚠️ If you notice any spurious failure please add them to the denylist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

Footnotes

1. re-run the experiment with crates=https://crater-reports.s3.amazonaws.com/pr-145330/retry-regressed-list.txt ↩