Skip to content

Implementation: #[feature(nonpoison_once)] #144653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

connortsui20
Copy link
Contributor

@connortsui20 connortsui20 commented Jul 29, 2025

Tracking Issue: #134645

This PR continues the effort made in #144022 by adding the implementation of nonpoison::once.

Many of the changes here are similar to the changes made to implement nonpoison::mutex.

Note that even though there were FIXMEs for changing OnceLock and LazyLock to use the nonpoison variant, that is not correct as both rely on poisoning behavior to operate correctly.

Related PRs

@rustbot
Copy link
Collaborator

rustbot commented Jul 29, 2025

r? @ChrisDenton

rustbot has assigned @ChrisDenton.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jul 29, 2025
@rust-log-analyzer

This comment has been minimized.

Adds the equivalent `nonpoison` types to the `poison::once` module.
These types and implementations are gated under the `nonpoison_once`
feature gate.
Both implementations require poisoning support.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants